Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: place download section in toh to the top #36567

Closed
wants to merge 2 commits into from
Closed

docs: place download section in toh to the top #36567

wants to merge 2 commits into from

Conversation

ajitsinghkaler
Copy link
Contributor

this is part of a larger effort to standardise download sections on angular.io

This commit partially addresses #35459

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

No standardized download exampes

Issue Number: #35459

What is the new behavior?

Standardized download examples

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from StephenFluin April 10, 2020 17:13
@ngbot ngbot bot added this to the needsTriage milestone Apr 13, 2020
@kapunahelewong kapunahelewong added effort2: days target: patch This PR is targeted for the next patch release risk: low type: bug/fix labels Apr 15, 2020
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Apr 15, 2020
@kapunahelewong kapunahelewong added this to In Review in docs Apr 15, 2020
kapunahelewong
kapunahelewong approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@kapunahelewong kapunahelewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @ajitsinghkaler! Looks good to me, but I'm also requesting review from another docs team member so we have consensus.

@mary-poppins
Copy link

You can preview 3330a4f at https://pr36567-3330a4f.ngbuilds.io/.

jbogarthyde
jbogarthyde approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@jbogarthyde jbogarthyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like just the right thing to do.
I added the preview tag-- I'd like to see how it looks on the page.

jbogarthyde
jbogarthyde reviewed Apr 15, 2020
View reviewed changes
aio/content/tutorial/toh-pt5.md
@@ -13,6 +13,13 @@ When you’re done, users will be able to navigate the app like this:
<img src='generated/images/guide/toh/nav-diagram.png' alt="View navigations">
</div>

<div class="alert is-helpful">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking at the preview, I think you might consider putting this link above the image, to make it more visible at the top of the page.
I would put it right after the bullet list.

@ajitsinghkaler
Copy link
Contributor Author

ajitsinghkaler commented Apr 17, 2020 •
edited

@jbogarthyde @kapunahelewong added the suggestions, please check and add the merge label

@mary-poppins
Copy link

You can preview 90537eb at https://pr36567-90537eb.ngbuilds.io/.

@jbogarthyde
Copy link
Contributor

LGTM

@ajitsinghkaler
Copy link
Contributor Author

@StephenFluin can you please review this

@ajitsinghkaler
Copy link
Contributor Author

@StephenFluin Can you please review this

@ajitsinghkaler
Copy link
Contributor Author

@jbogarthyde @kapunahelewong can we get this merged

@kapunahelewong
Copy link
Contributor

Thanks for the tag, @ajitsinghkaler. I've requested @aikidave to review to help move this forward.

@ajitsinghkaler
Copy link
Contributor Author

@aikidave @StephenFluin can you help me get this merged

@aikithoughts aikithoughts added the action: merge The PR is ready for merge by the caretaker label Jun 8, 2020
@aikithoughts aikithoughts removed the request for review from StephenFluin June 8, 2020 13:35
@ajitsinghkaler @atscott
docs: place download section in toh to the top
0faf438 
this is part of a larger effort to standardise download sections on angular.io

This commit partially addresses angular#35459
@ajitsinghkaler @atscott
fixup! docs: place download section in toh to the top
c7bf2fb
@mary-poppins
Copy link

You can preview c7bf2fb at https://pr36567-c7bf2fb.ngbuilds.io/.

atscott pushed a commit that referenced this pull request Jun 8, 2020
@ajitsinghkaler @atscott
docs: place download section in toh to the top (#36567)
8d1d6e8 
this is part of a larger effort to standardise download sections on angular.io

This commit partially addresses #35459

PR Close #36567
@atscott atscott closed this in 0cb0f66 Jun 8, 2020
@ajitsinghkaler ajitsinghkaler deleted the download-examples-toh branch June 9, 2020 03:20
ngwattcos pushed a commit to ngwattcos/angular that referenced this pull request Jun 25, 2020
@ajitsinghkaler @ngwattcos
docs: place download section in toh to the top (angular#36567)
dff290f 
this is part of a larger effort to standardise download sections on angular.io

This commit partially addresses angular#35459

PR Close angular#36567
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 10, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
@ajitsinghkaler @profanis
docs: place download section in toh to the top (angular#36567)
f384c59 
this is part of a larger effort to standardise download sections on angular.io

This commit partially addresses angular#35459

PR Close angular#36567
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jbogarthyde jbogarthyde jbogarthyde approved these changes

@kapunahelewong kapunahelewong kapunahelewong approved these changes

@aikithoughts aikithoughts aikithoughts approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes effort2: days risk: low state: needs doc team review target: patch This PR is targeted for the next patch release type: bug/fix
Projects
docs
In Review
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ajitsinghkaler @mary-poppins @jbogarthyde @kapunahelewong @aikithoughts @atscott @googlebot